Hi Vladimir, On Thu, Oct 31, 2024 at 01:59:45PM +0200, Vladimir Zapolskiy wrote: > On 10/31/24 13:41, Andi Shyti wrote: > > On Thu, Oct 31, 2024 at 01:13:24PM +0200, Vladimir Zapolskiy wrote: > > > On 10/31/24 12:44, Andi Shyti wrote: > > > > On Tue, Oct 29, 2024 at 10:09:31AM +0800, Jiapeng Chong wrote: > > > > > Variable ret is not effectively used, so delete it. > > > > > > > > > > drivers/i2c/busses/i2c-qcom-cci.c:526:16: warning: variable ‘cci_clk_rate’ set but not used. > > > > > > > > > > Reported-by: Abaci Robot <abaci@xxxxxxxxxxxxxxxxx> > > > > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11532 > > > > > Signed-off-by: Jiapeng Chong <jiapeng.chong@xxxxxxxxxxxxxxxxx> > > > > > > > > thanks for your patch! Applied to i2c/i2c-host > > > > > > > > Thanks, > > > > Andi > > > > > > > > > > FWIW I've noticed that my Reviewed-by tag was added to the accepted change, > > > while it was the conditional one... Actually I don't know how to be aware > > > of such nuances, if only b4 tool is used, likely there is no way for it. > > > > I thought the change that made your r-b conditional was the > > Fixes tag, right? That is added. Have I missed anything? > > ah, no, it was about the copy-pasted commit message, which mentions a much > more popular 'ret' local variable. oh yes, the new commit message says: "Variable cci_clk_rate is not effectively used, so delete it." I'm sorry, I will fix it. Thanks, Andi
