Re: [PATCH v16 5/5] iommu/arm-smmu: add ACTLR data and support for qcom_smmu_500

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 10/29/2024 2:46 AM, Rob Clark wrote:
On Tue, Oct 8, 2024 at 5:55 AM Bibek Kumar Patro
<quic_bibekkum@xxxxxxxxxxx> wrote:

Add ACTLR data table for qcom_smmu_500 including
corresponding data entry and set prefetch value by
way of a list of compatible strings.

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
Signed-off-by: Bibek Kumar Patro <quic_bibekkum@xxxxxxxxxxx>
---
  drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c | 24 ++++++++++++++++++++++
  1 file changed, 24 insertions(+)

diff --git a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
index 2d2c1e75632c..dd4fb883ebcd 100644
--- a/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
+++ b/drivers/iommu/arm/arm-smmu/arm-smmu-qcom.c
@@ -25,8 +25,31 @@

  #define CPRE                   (1 << 1)
  #define CMTLB                  (1 << 0)
+#define PREFETCH_SHIFT         8
+#define PREFETCH_DEFAULT       0
+#define PREFETCH_SHALLOW       (1 << PREFETCH_SHIFT)
+#define PREFETCH_MODERATE      (2 << PREFETCH_SHIFT)
+#define PREFETCH_DEEP          (3 << PREFETCH_SHIFT)
  #define GFX_ACTLR_PRR          (1 << 5)

+static const struct of_device_id qcom_smmu_actlr_client_of_match[] = {
+       { .compatible = "qcom,adreno",
+                       .data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
+       { .compatible = "qcom,adreno-gmu",
+                       .data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
+       { .compatible = "qcom,adreno-smmu",
+                       .data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
+       { .compatible = "qcom,fastrpc",
+                       .data = (const void *) (PREFETCH_DEEP | CPRE | CMTLB) },
+       { .compatible = "qcom,sc7280-mdss",
+                       .data = (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) },
+       { .compatible = "qcom,sc7280-venus",
+                       .data = (const void *) (PREFETCH_SHALLOW | CPRE | CMTLB) },
+       { .compatible = "qcom,sm8550-mdss",
+                       .data = (const void *) (PREFETCH_DEFAULT | CMTLB) },
+       { }
+};

I guess by now there are some more entries to add
("qcom,x1e80100-mdss", for example), but I guess those could be
followup patches

Reviewed-by: Rob Clark <robdclark@xxxxxxxxx>


Thanks everyone for valuable inputs, reviews and ack.

regards,
Bibek

+
  static struct qcom_smmu *to_qcom_smmu(struct arm_smmu_device *smmu)
  {
         return container_of(smmu, struct qcom_smmu, smmu);
@@ -640,6 +663,7 @@ static const struct qcom_smmu_match_data qcom_smmu_500_impl0_data = {
         .impl = &qcom_smmu_500_impl,
         .adreno_impl = &qcom_adreno_smmu_500_impl,
         .cfg = &qcom_smmu_impl0_cfg,
+       .client_match = qcom_smmu_actlr_client_of_match,
  };

  /*
--
2.34.1





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux