On Mon, Oct 28, 2024 at 07:48:18PM +0100, Gabor Juhos wrote: > Since both the 'alpha' and 'alpha_hi' members of the configuration is > initialized (the latter is implicitly) with zero values, the output > rate of the PLL will be the same whether alpha mode is enabled or not. > > Remove the initialization of the alpha* members to make it clear that > the alpha mode is not required to get the desired output rate. > > Despite that enabling alpha mode is not needed for the initial > configuration, the set_rate() op might require that it is enabled > already. In this particular case however, the clk_alpha_pll_set_rate() > function will get reset the ALPHA_EN bit when the PLL's rate changes, > so dropping 'alpha_en_mask' is safe. > > No functional changes intended, compile tested only. > > Signed-off-by: Gabor Juhos <j4g8y7@xxxxxxxxx> > --- > Changes in v2: > - extend the commit message to indicate that dropping 'alpha_en_mask' is safe > - Link to v1: https://lore.kernel.org/r/20241021-alpha-mode-cleanup-v1-4-55df8ed73645@xxxxxxxxx > --- > drivers/clk/qcom/dispcc-qcm2290.c | 2 -- > 1 file changed, 2 deletions(-) > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry
