On 10/26/2024 1:41 AM, Konrad Dybcio wrote: > On 10.10.2024 12:08 PM, Jingyi Wang wrote: >> Add LLCC configuration for the QCS8300 platform. There is an errata on >> LB_CNT information on QCS8300 platform, override the value to get the >> right number of banks. >> >> Signed-off-by: Jingyi Wang <quic_jingyw@xxxxxxxxxxx> >> --- >> drivers/soc/qcom/llcc-qcom.c | 72 ++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 72 insertions(+) >> >> diff --git a/drivers/soc/qcom/llcc-qcom.c b/drivers/soc/qcom/llcc-qcom.c >> index a470285f54a8..d867b1596725 100644 >> --- a/drivers/soc/qcom/llcc-qcom.c >> +++ b/drivers/soc/qcom/llcc-qcom.c >> @@ -2225,6 +2225,56 @@ static const struct llcc_slice_config sm8650_data[] = { >> }, >> }; >> >> +static const struct llcc_slice_config qcs8300_data[] = { > > This part looks good and in line with the data I have > > [...] > >> >> + /* LB_CNT information is wrong on QCS8300, override the value */ >> + if (of_device_is_compatible(dev->of_node, "qcom,qcs8300-llcc")) { >> + num_banks = 4; >> + drv_data->num_banks = 4; >> + } > > This, please rebase on <20241025-sar2130p-llcc-v2-0-7455dc40e952@xxxxxxxxxx> > and reuse the thing added there Well noted, thanks for review. > > Konrad Thanks, Jingyi