On 8.10.2024 4:56 PM, Rob Herring (Arm) wrote: > > On Mon, 07 Oct 2024 21:59:25 -0500, Joel Selvaraj wrote: >> In the first patch, I have enabled the qupv3_id_1 and gpi_dma1 as they >> are required for configuring touchscreen. Also added the pinctrl configurations. >> These are common for both the Poco F1 Tianma and EBBG panel variant. >> >> In the subsequent patches, I have enabled support for the Novatek NT36672a >> touchscreen and FocalTech FT8719 touchscreen that are used in the Poco F1 >> Tianma and EBBG panel variant respectively. >> >> Signed-off-by: Joel Selvaraj <foss@xxxxxxxxxxxxxxxx> >> --- [...] > New warnings running 'make CHECK_DTBS=y qcom/sdm845-xiaomi-beryllium-ebbg.dtb qcom/sdm845-xiaomi-beryllium-tianma.dtb' for 20241007-pocof1-touchscreen-support-v1-0-db31b21818c5@xxxxxxxxxxxxxxxx: > > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-ebbg.dtb: touchscreen@38: 'panel' does not match any of the regexes: 'pinctrl-[0-9]+' > from schema $id: http://devicetree.org/schemas/input/touchscreen/edt-ft5x06.yaml# This needs a bindings update > arch/arm64/boot/dts/qcom/sdm845-xiaomi-beryllium-tianma.dtb: pinctrl@3400000: ts-int-default-state: 'oneOf' conditional failed, one must be fixed: > 'bias-pull-down', 'drive-strength', 'function', 'input-enable', 'pins' do not match any of the regexes: '-pins$', 'pinctrl-[0-9]+' > False schema does not allow True > from schema $id: http://devicetree.org/schemas/pinctrl/qcom,sdm845-pinctrl.yaml# I think these warnings are unhappy about input-enable (which is not really a thing on TLMM, see: e49eabe3e13f ("pinctrl: qcom: Support OUTPUT_ENABLE; deprecate INPUT_ENABLE") Konrad
