Hi Eugen, kernel test robot noticed the following build errors: [auto build test ERROR on linus/master] [also build test ERROR on v6.12-rc4 next-20241025] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Eugen-Hristev/soc-qcom-Rework-BCM_TCS_CMD-macro/20241025-165212 base: linus/master patch link: https://lore.kernel.org/r/20241025084823.475199-1-eugen.hristev%40linaro.org patch subject: [PATCH] soc: qcom: Rework BCM_TCS_CMD macro config: x86_64-buildonly-randconfig-004-20241026 (https://download.01.org/0day-ci/archive/20241026/202410261552.E8TiGYdV-lkp@xxxxxxxxx/config) compiler: clang version 19.1.2 (https://github.com/llvm/llvm-project 7ba7d8e2f7b6445b60679da826210cdde29eaf8b) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241026/202410261552.E8TiGYdV-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202410261552.E8TiGYdV-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): >> drivers/clk/qcom/clk-rpmh.c:270:14: error: call to undeclared function 'u32_encode_bits'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration] 270 | cmd.data = BCM_TCS_CMD(1, enable, 0, cmd_state); | ^ include/soc/qcom/tcs.h:71:3: note: expanded from macro 'BCM_TCS_CMD' 71 | (u32_encode_bits(commit, BCM_TCS_CMD_COMMIT_MASK) | \ | ^ 1 error generated. vim +/u32_encode_bits +270 drivers/clk/qcom/clk-rpmh.c 9c7e47025a6b9a Taniya Das 2018-05-09 250 04053f4d23a41b David Dai 2019-01-24 251 static int clk_rpmh_bcm_send_cmd(struct clk_rpmh *c, bool enable) 04053f4d23a41b David Dai 2019-01-24 252 { 04053f4d23a41b David Dai 2019-01-24 253 struct tcs_cmd cmd = { 0 }; 04053f4d23a41b David Dai 2019-01-24 254 u32 cmd_state; 2cf7a4cbcb4e10 Stephen Boyd 2020-03-09 255 int ret = 0; 04053f4d23a41b David Dai 2019-01-24 256 04053f4d23a41b David Dai 2019-01-24 257 mutex_lock(&rpmh_clk_lock); 04053f4d23a41b David Dai 2019-01-24 258 if (enable) { 04053f4d23a41b David Dai 2019-01-24 259 cmd_state = 1; 04053f4d23a41b David Dai 2019-01-24 260 if (c->aggr_state) 04053f4d23a41b David Dai 2019-01-24 261 cmd_state = c->aggr_state; 2cf7a4cbcb4e10 Stephen Boyd 2020-03-09 262 } else { 2cf7a4cbcb4e10 Stephen Boyd 2020-03-09 263 cmd_state = 0; 04053f4d23a41b David Dai 2019-01-24 264 } 04053f4d23a41b David Dai 2019-01-24 265 a4e5af27e6f6a8 Mike Tipton 2024-08-09 266 cmd_state = min(cmd_state, BCM_TCS_CMD_VOTE_MASK); a4e5af27e6f6a8 Mike Tipton 2024-08-09 267 2cf7a4cbcb4e10 Stephen Boyd 2020-03-09 268 if (c->last_sent_aggr_state != cmd_state) { 04053f4d23a41b David Dai 2019-01-24 269 cmd.addr = c->res_addr; 6311b6521bcc80 Jordan Crouse 2019-08-05 @270 cmd.data = BCM_TCS_CMD(1, enable, 0, cmd_state); 04053f4d23a41b David Dai 2019-01-24 271 29f66b625281a3 Stephen Boyd 2022-05-17 272 /* 29f66b625281a3 Stephen Boyd 2022-05-17 273 * Send only an active only state request. RPMh continues to 29f66b625281a3 Stephen Boyd 2022-05-17 274 * use the active state when we're in sleep/wake state as long 29f66b625281a3 Stephen Boyd 2022-05-17 275 * as the sleep/wake state has never been set. 29f66b625281a3 Stephen Boyd 2022-05-17 276 */ dad4e7fda4bdc1 Mike Tipton 2020-02-14 277 ret = clk_rpmh_send(c, RPMH_ACTIVE_ONLY_STATE, &cmd, enable); 04053f4d23a41b David Dai 2019-01-24 278 if (ret) { 04053f4d23a41b David Dai 2019-01-24 279 dev_err(c->dev, "set active state of %s failed: (%d)\n", 04053f4d23a41b David Dai 2019-01-24 280 c->res_name, ret); 2cf7a4cbcb4e10 Stephen Boyd 2020-03-09 281 } else { 04053f4d23a41b David Dai 2019-01-24 282 c->last_sent_aggr_state = cmd_state; 2cf7a4cbcb4e10 Stephen Boyd 2020-03-09 283 } 2cf7a4cbcb4e10 Stephen Boyd 2020-03-09 284 } 04053f4d23a41b David Dai 2019-01-24 285 04053f4d23a41b David Dai 2019-01-24 286 mutex_unlock(&rpmh_clk_lock); 04053f4d23a41b David Dai 2019-01-24 287 2cf7a4cbcb4e10 Stephen Boyd 2020-03-09 288 return ret; 04053f4d23a41b David Dai 2019-01-24 289 } 04053f4d23a41b David Dai 2019-01-24 290 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki