On Fri, Oct 25, 2024 at 2:17 PM Johan Hovold <johan+linaro@xxxxxxxxxx> wrote: > Commit 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength > mapping") fixed a long-standing issue in the Qualcomm SPMI PMIC gpio > driver which had the 'low' and 'high' drive strength settings switched > but failed to update the debugfs interface which still gets this wrong. > > Fix the debugfs code so that the exported values match the hardware > settings. > > Note that this probably means that most devicetrees that try to describe > the firmware settings got this wrong if the settings were derived from > debugfs. Before the above mentioned commit the settings would have > actually matched the firmware settings even if they were described > incorrectly, but now they are inverted. > > Fixes: 723e8462a4fe ("pinctrl: qcom: spmi-gpio: Fix the GPIO strength mapping") > Fixes: eadff3024472 ("pinctrl: Qualcomm SPMI PMIC GPIO pin controller driver") > Cc: Anjelique Melendez <quic_amelende@xxxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx # 3.19 > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> Patch applied for fixes, thanks for digging into this Johan! Yours, Linus Walleij