On Wed, Oct 23, 2024 at 03:51:47PM +0530, Sibi Sankar wrote: > The domain attributes returned by the perf protocol can end up > reporting identical names across domains, resulting in debugfs > node creation failure. Fix this failure by ensuring that pm domains > get a unique name using ida in pm_genpd_init. > > Logs: [X1E reports 'NCC' for all its scmi perf domains] > debugfs: Directory 'NCC' with parent 'pm_genpd' already present! > debugfs: Directory 'NCC' with parent 'pm_genpd' already present! > > Reported-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > Closes: https://lore.kernel.org/lkml/ZoQjAWse2YxwyRJv@xxxxxxxxxxxxxxxxxxxx/ > Fixes: 718072ceb211 ("PM: domains: create debugfs nodes when adding power domains") > Suggested-by: Ulf Hansson <ulf.hansson@xxxxxxxxxx> > Signed-off-by: Sibi Sankar <quic_sibis@xxxxxxxxxxx> > --- > > v3: > * Update device names only when a name collision occurs [Dmitry/Ulf] > * Drop Johan's T-b from "fix debugfs node creation failure" Also seems to do the trick: Tested-by: Johan Hovold <johan+linaro@xxxxxxxxxx> But perhaps you could consider starting enumerating the duplicate domains from 2 (or 1) instead of 0?: NCC_1 on 0 NCC_0 on 0 NCC on 0 Johan
