Hi Chris,
@@ -560,6 +560,11 @@ int qrtr_endpoint_post(struct qrtr_endpoint *ep, const
void *data, size_t len)
if (!size || len != ALIGN(size, 4) + hdrlen)
goto err;
+ /* Don't allow remote lookups */
+ if (cb->type == QRTR_TYPE_NEW_LOOKUP ||
+ cb->type == QRTR_TYPE_DEL_LOOKUP)
+ goto err;
+
Just curious, was this case observed? I thought we blocked clients from sending
this control message to remotes and I didnt think the ns broadcasts it either.
No I didn't see this in practice, so this patch is not strictly necessary.
One thing I thought about originally was to remove the check in ns.c in order to
extend struct qrtr_lookup with the endpoint id: an application interested only
in services on a certain endpoint could send NEW_LOOKUP with the endpoint id
included as a CMSG header. It made the proposal more complicated though and I
didn't think it was really needed since QRTR_BIND_ENDPOINT was the better tool
for this kind of use case.
Regards,
-Denis
