On Mon, 21 Oct 2024 at 10:29, Neil Armstrong <neil.armstrong@xxxxxxxxxx> wrote: > > On 18/10/2024 23:49, Dmitry Baryshkov wrote: > > Allow YCbCr 420 output for HDMI and DisplayPort connectors. Other > > bridges in the chain still might limit YCbCr 420 support on the > > corresponding connector. > > > > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > --- > > drivers/gpu/drm/bridge/display-connector.c | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/drivers/gpu/drm/bridge/display-connector.c b/drivers/gpu/drm/bridge/display-connector.c > > index ab8e00baf3f1..aab9ce7be94c 100644 > > --- a/drivers/gpu/drm/bridge/display-connector.c > > +++ b/drivers/gpu/drm/bridge/display-connector.c > > @@ -270,6 +270,10 @@ static int display_connector_probe(struct platform_device *pdev) > > /* All the supported connector types support interlaced modes. */ > > conn->bridge.interlace_allowed = true; > > > > + if (type == DRM_MODE_CONNECTOR_HDMIA || > > + type == DRM_MODE_CONNECTOR_DisplayPort) > > + conn->bridge.ycbcr_420_allowed = true; > > + > > /* Get the optional connector label. */ > > of_property_read_string(pdev->dev.of_node, "label", &label); > > > > > > I think we should make sure all HDMI bridges can filter out 420 before > landing this, no ? No, it's the other way around: if one of the bridges in a chain doesn't set 420_allowed, then 420_allowed won't be set for the connector, disallowing YCbCr 420 modes. Before this patchset the bridge / platform drivers had to manually set the flag on the created connector (see dw-hdmi + meson-encoder-hdmi or msm/dp). -- With best wishes Dmitry
