On Fri, Oct 18, 2024 at 03:53:22PM +0530, Krishna Kurapati wrote: > > > On 10/18/2024 3:41 PM, Dmitry Baryshkov wrote: > > On Fri, Oct 18, 2024 at 05:01:48PM +0800, Tingwei Zhang wrote: > > > On 10/18/2024 4:06 PM, Dmitry Baryshkov wrote: > > > > On Fri, 18 Oct 2024 at 10:48, Tingwei Zhang <quic_tingweiz@xxxxxxxxxxx> wrote: > > > > > > > > > > On 10/18/2024 2:27 AM, Dmitry Baryshkov wrote: > > > > > > On Thu, 17 Oct 2024 at 16:07, Krishna Kurapati > > > > > > <quic_kriskura@xxxxxxxxxxx> wrote: > > > > > > > > > > > > > > Provide PHY configuration for the USB QMP PHY for QCS615 Platform. > > > > > > > > > > > > > > Signed-off-by: Krishna Kurapati <quic_kriskura@xxxxxxxxxxx> > > > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > > > > > > > > > After checking platform details, > > > > > > > > > > > > Unreviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> > > > > > > > > > > > > Please perform global s/QCS615/SM6150/ and s/qcs615/sm6150/ > > > > > > > > > > QCS615 and SM6150 are different variants of the same SoC. QCS615 is an > > > > > IoT variant, while SM6150 is a mobile variant. We are currently adding > > > > > QCS615 SoC support to the upstream Kernel, as it is in an active > > > > > development stage and we anticipate many products based on this SoC. On > > > > > the other hand, the SM6150 is an older mobile platform that is unlikely > > > > > to be used in new designs. For a product introduction of the QCS615, > > > > > please refer to > > > > > https://docs.qualcomm.com/bundle/publicresource/87-83838-1_REV_A_Qualcomm_IQ6_Series_Product_Brief.pdf > > > > > > > > Yes, I guessed so. It would have been nice if it was documented this > > > > way from the beginning. > > > > > > > > Please note that we usually get support for the mobile SoC first. So > > > > in most of the cases devices use mobile compatible even for IoT > > > > platforms, see qrb5165, qrb4210, qcm6490 and other similar platforms. > > > > I simply asked to follow the established pattern. > > > > > > Yes, we start from mobile variant for most of the platforms. There are some > > > exceptions like sc7180 and sc7280 which we started from compute variant > > > since they are widely used by compute platform on upstream Kernel. I think > > > we have similar case here. QCS615 will be widely used by IOT products on > > > upstream Kernel. We should have clarified this from beginning so there's no > > > ambiguity. > > > > After offline discussion with Krzysztof, I'll lift my objection, so > > still Reviewed-by. > > > > Thanks Dmitry. > > Can you help review patch-4 of the series. I made the changes you suggested > on v1 (uppercase to lowercase and removing un-necessary re-inits). done -- With best wishes Dmitry
