On Mon, Oct 14, 2024 at 05:58:23PM +0300, Abel Vesa wrote: > Allowing these GDSCs to collapse makes the QMP combo PHYs lose their > configuration on machine suspend. Currently, the QMP combo PHY driver > doesn't reinitialise the HW on resume. Under such conditions, the USB > SuperSpeed support is broken. To avoid this, mark the pwrsts flags with > RET_ON. This has been already done for USB 0 and 1 SS PHY GDSCs, > Do this USB MP SS1 PHY GDSC config. The USB MP SS1 PHY GDSC already has > it. s/Do this/Do this also for the/ (or similar) The last sentence was supposed to say "SS0". > Fixes: 161b7c401f4b ("clk: qcom: Add Global Clock controller (GCC) driver for X1E80100") > Signed-off-by: Abel Vesa <abel.vesa@xxxxxxxxxx> Looks good otherwise: Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>