On Wed, Oct 16, 2024 at 11:37:27AM +0200, Uwe Kleine-König wrote: > Hello, > > On Sun, Oct 13, 2024 at 11:27:49PM +0200, Jan Petrous via B4 Relay wrote: > > +static struct platform_driver s32_dwmac_driver = { > > + .probe = s32_dwmac_probe, > > + .remove_new = stmmac_pltfr_remove, > > + .driver = { > > + .name = "s32-dwmac", > > + .pm = &stmmac_pltfr_pm_ops, > > + .of_match_table = s32_dwmac_match, > > + }, > > +}; > > +module_platform_driver(s32_dwmac_driver); > > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. Please just drop "_new". > Thank you, I was not aware of it. Will be included in v4. /Jan