On 15/10/2024 08:21, Yijie Yang wrote: > > > On 2024-10-10 14:15, Krzysztof Kozlowski wrote: >> On Thu, Oct 10, 2024 at 10:03:45AM +0800, Yijie Yang wrote: >>> Add compatible for the MAC controller on qcs8300 platforms. >>> Since qcs8300 shares the same EMAC as sa8775p, so it fallback to the >>> compatible. >>> >>> Signed-off-by: Yijie Yang <quic_yijiyang@xxxxxxxxxxx> >>> --- >>> Documentation/devicetree/bindings/net/qcom,ethqos.yaml | 4 ++++ >>> 1 file changed, 4 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> index 8cf29493b822..3ee5367bdde1 100644 >>> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml >>> @@ -23,6 +23,10 @@ properties: >>> - enum: >>> - qcom,qcs615-ethqos >>> - const: qcom,sm8150-ethqos >>> + - items: >>> + - enum: >>> + - qcom,qcs8300-ethqos >>> + - const: qcom,sa8775p-ethqos >> >> This block should go before earlier qcs615, to keep order by fallback. --------------------------------------------------^^^^^^^^^^^^^^^^^^^^^^^ Here > > Why this block should positioned before qcs615, given that it comes > later in alphabetical order? sa < sm Best regards, Krzysztof