On Thu, Oct 10, 2024 at 09:59:11PM GMT, Miaoqing Pan wrote: > > > On 10/10/2024 9:47 PM, Dmitry Baryshkov wrote: > > On Thu, Oct 10, 2024 at 09:29:02PM GMT, Miaoqing Pan wrote: > > > Add a node for the PMU module of the WCN6855 present on the sa8775p-ride > > > board. Assign its LDO power outputs to the existing WiFi/Bluetooth module. > > > > > > Signed-off-by: Miaoqing Pan <quic_miaoqing@xxxxxxxxxxx> > > > --- > > > v2: > > > - fix wcn6855-pmu compatible to "qcom,wcn6855-pmu". > > > - relocate pcieport0 node in alphabetical order. > > > v3: > > > - add 'qcom,ath11k-calibration-variant = "SA8775P"'. > > > v4: > > > - update 'ath11k-calibration-variant' to "Ride". > > > > What exactly is Ride? Is there just one Ride board? I thought it's a > > board family name. > > I just follow the existing boards, 'Ride' is a board name. Both 'Ride' and > 'Ride r3' boards are attached with WCN6855 WLAN chip. > > arch/arm64/boot/dts/qcom/qcm6490-fairphone-fp5.dts:1112: > qcom,ath11k-calibration-variant = "Fairphone_5"; > arch/arm64/boot/dts/qcom/qcm6490-shift-otter.dts:958: > qcom,ath11k-calibration-variant = "SHIFTphone_8"; > arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts:879: > qcom,ath11k-calibration-variant = "LE_X13S"; There definitely are other Ride boards. I see patches related to qcs8300-ride. Does that board use the same BDF file? If not, Qualcomm_SA8775P_Ride or QC_SA8775P_Ride sounds like a better approach. > > > > Also, could you please extend the commit message with messages from the > > ath11k driver, showing the chip_id / board_id ? > > The board-id is non 0xff, do you still think we need to add > 'qcom,ath11k-calibration-variant', following is the WLAN chip board data > info, > > bus=pci,vendor=17cb,device=1103,subsystem-vendor=17cb,subsystem-device=0108,qmi-chip-id=2,qmi-board-id=519.bin I'd ask Kalle / Jeff to answer this question. Are we sure that this board-id won't be reused by any else device? -- With best wishes Dmitry
