On Thu, 10 Oct 2024 at 13:11, Johan Hovold <johan@xxxxxxxxxx> wrote: > > On Thu, Oct 10, 2024 at 12:55:48PM +0300, Dmitry Baryshkov wrote: > > On Thu, 10 Oct 2024 at 10:44, Johan Hovold <johan+linaro@xxxxxxxxxx> wrote: > > > > > > When using the in-kernel pd-mapper on x1e80100, client drivers often > > > fail to communicate with the firmware during boot, which specifically > > > breaks battery and USB-C altmode notifications. This has been observed > > > to happen on almost every second boot (41%) but likely depends on probe > > > order: > > > > > > pmic_glink_altmode.pmic_glink_altmode pmic_glink.altmode.0: failed to send altmode request: 0x10 (-125) > > > pmic_glink_altmode.pmic_glink_altmode pmic_glink.altmode.0: failed to request altmode notifications: -125 > > > > > > ucsi_glink.pmic_glink_ucsi pmic_glink.ucsi.0: failed to send UCSI read request: -125 > > > > > > qcom_battmgr.pmic_glink_power_supply pmic_glink.power-supply.0: failed to request power notifications > > > > > > In the same setup audio also fails to probe albeit much more rarely: > > > > > > PDR: avs/audio get domain list txn wait failed: -110 > > > PDR: service lookup for avs/audio failed: -110 > > > > > > Chris Lew has provided an analysis and is working on a fix for the > > > ECANCELED (125) errors, but it is not yet clear whether this will also > > > address the audio regression. > > > > > > Even if this was first observed on x1e80100 there is currently no reason > > > to believe that these issues are specific to that platform. > > > > > > Disable the in-kernel pd-mapper for now, and make sure to backport this > > > to stable to prevent users and distros from migrating away from the > > > user-space service. > > > > > > Fixes: 1ebcde047c54 ("soc: qcom: add pd-mapper implementation") > > > Cc: stable@xxxxxxxxxxxxxxx # 6.11 > > > Link: https://lore.kernel.org/lkml/Zqet8iInnDhnxkT9@xxxxxxxxxxxxxxxxxxxx/ > > > Signed-off-by: Johan Hovold <johan+linaro@xxxxxxxxxx> > > > > Please don't break what is working. pd_mapper is working on all > > previous platforms. I suggest reverting commit bd6db1f1486e ("soc: > > qcom: pd_mapper: Add X1E80100") instead. > > As I tried to explain in the commit message, there is currently nothing > indicating that these issues are specific to x1e80100 (even if you may > not hit them in your setup depending on things like probe order). I have the understanding that the issues are related to the ADSP switching the firmware on the fly, which is only used on X1E8. > > Let's disable it until the underlying bugs have been addressed. > > Johan -- With best wishes Dmitry