On Mon, Sep 30, 2024 at 12:30:37PM +0200, Bartosz Golaszewski wrote:
> From: Konrad Dybcio <konradybcio@xxxxxxxxxx>
>
> Add nodes for the WCN6855 PMU, the WLAN module and relevant regulators
> and pin functions to fully describe how the wifi is actually wired on
> this platform.
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx>
> Signed-off-by: Konrad Dybcio <konradybcio@xxxxxxxxxx>
> [Bartosz:
> - write the commit message,
> - rebase Konrad's commit,
> - fix one of the supplies' name]
> Co-developed-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
First, make sure to CC people that help review your patches.
> ---
> arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 110 ++++++++++++++++++++++
> 1 file changed, 110 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> index 6020582b0a59..28721570c59f 100644
> --- a/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> +++ b/arch/arm64/boot/dts/qcom/sc8280xp-crd.dts
> @@ -177,6 +177,17 @@ vreg_misc_3p3: regulator-misc-3p3 {
> regulator-always-on;
> };
>
> + vreg_s10b: regulator-s10b {
> + compatible = "regulator-fixed";
> +
> + regulator-name = "VREG_S10B";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> +
> + regulator-always-on;
> + regulator-boot-on;
> + };
Again, this is not a fixed regulator. It's an supply from one of the
PMICs that are already described in DT.
> +
> vreg_wlan: regulator-wlan {
> compatible = "regulator-fixed";
> +&pcie4_port0 {
> + wifi@0 {
> + compatible = "pci17cb,1103";
> + reg = <0x10000 0x0 0x0 0x0 0x0>;
> +
> + vddrfacmn-supply = <&vreg_pmu_rfa_cmn_0p8>;
> + vddaon-supply = <&vreg_pmu_aon_0p8>;
> + vddwlcx-supply = <&vreg_pmu_wlcx_0p8>;
> + vddwlmx-supply = <&vreg_pmu_wlmx_0p8>;
> + vddpcie1p8-supply = <&vreg_pmu_pcie_1p8>;
> + vddpcie0p9-supply = <&vreg_pmu_pcie_0p9>;
> + vddrfa0p8-supply = <&vreg_pmu_rfa_0p8>;
> + vddrfa1p2-supply = <&vreg_pmu_rfa_1p2>;
> + vddrfa1p8-supply = <&vreg_pmu_rfa_1p7>;
> +
> + qcom,ath11k-calibration-variant = "QC_8280XP_CRD";
Not "SC8280XP"?
> + };
> +};
> +
> &pmc8280c_lpg {
> status = "okay";
> };
> @@ -829,6 +933,12 @@ reset-pins {
> };
> };
>
> + wlan_en: wlan-en-state {
> + pins = "gpio134";
> + function = "gpio";
> + bias-pull-down;
We don't want a pull-down enabled on an active high enable signal.
> + };
Please keep the nodes sorted by name.
> +
> nvme_reg_en: nvme-reg-en-state {
> pins = "gpio135";
> function = "gpio";
Johan
