Re: [PATCH 1/3] dt-bindings: mailbox: qcom,cpucp-mbox: Add sc7280 cpucp mailbox instance

[Shivnandan Kumar <quic_kshivnan@xxxxxxxxxxx>]

thanks Rob for reviewing this patch.


On 9/25/2024 4:55 AM, Rob Herring wrote:
> On Tue, Sep 24, 2024 at 10:39:39AM +0530, Shivnandan Kumar wrote:
> > sc7280 has a cpucp mailbox. Document them.
>
> And is different from the existing device how?

It is different with respect to the register placement.

Thanks,
Shivnandan

> > Signed-off-by: Shivnandan Kumar <quic_kshivnan@xxxxxxxxxxx>
> > ---
> >   .../devicetree/bindings/mailbox/qcom,cpucp-mbox.yaml         | 5 +++--
> >   1 file changed, 3 insertions(+), 2 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/mailbox/qcom,cpucp-mbox.yaml b/Documentation/devicetree/bindings/mailbox/qcom,cpucp-mbox.yaml
> > index f7342d04beec..4a7ea072a3c1 100644
> > --- a/Documentation/devicetree/bindings/mailbox/qcom,cpucp-mbox.yaml
> > +++ b/Documentation/devicetree/bindings/mailbox/qcom,cpucp-mbox.yaml
> > @@ -15,8 +15,9 @@ description:
> >
> >   properties:
> >     compatible:
> > -    items:
> > -      - const: qcom,x1e80100-cpucp-mbox
> > +    enum:
> > +      - qcom,x1e80100-cpucp-mbox
> > +      - qcom,sc7280-cpucp-mbox
> >
> >     reg:
> >       items:
> > --
> > 2.25.1