Hi Vladimir,
On 9/30/2024 5:23 PM, Vladimir Zapolskiy wrote:
@@ -1049,7 +1050,10 @@ static int csid_set_test_pattern(struct
csid_device *csid, s32 value)
tg->enabled = !!value;
- return csid->res->hw_ops->configure_testgen_pattern(csid, value);
+ if (hw_ops->configure_testgen_pattern)
+ return -EOPNOTSUPP;
+ else
+ return hw_ops->configure_testgen_pattern(csid, value);
}
/*
Here you accedentally break the TPG on all platforms and introduce a NULL
pointer dereference, please fix it.
Any generic/non-sm8550 support related changes like the part of this
one shall be split into a stand-alone generic change aside of the added
SM8550 platform support, it will simplify patch reviews and hunting bugs
like the one above.
Thanks for catching this. This is indeed a bug which is introduced by
this patch. And I will follow your suggestion to use a stand-alone
generic change for the TPG part.
Thanks,
Depeng
