On 16/08/2024 09:45, Depeng Shao wrote: > Hi Krzysztof, > > On 8/16/2024 3:01 PM, Krzysztof Kozlowski wrote: > >>> +required: >>> + - compatible >>> + - clocks >>> + - clock-names >>> + - interconnects >>> + - interconnect-names >>> + - interrupts >>> + - interrupt-names >>> + - iommus >>> + - power-domains >>> + - power-domain-names >>> + - reg >>> + - reg-names >>> + - vdda-phy-supply >>> + - vdda-pll-supply >> >> Order is still not as expected. I already commented on this - keep the >> same order as in "properties:" block. >> >> With the order fixed: >> >> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> The review tag was given to above code with above changes. If you are going to implement some more changes, including changing of orders of some lists or adding ports, then drop this tag and explicitly mention in patch changelog that tag was not added because of something. Best regards, Krzysztof
