On Fri, Sep 20, 2024 at 06:07:11PM GMT, Jinjie Ruan wrote: > It's important to undo pm_runtime_use_autosuspend() with > pm_runtime_dont_use_autosuspend() at driver exit time. > > But the pm_runtime_disable() and pm_runtime_dont_use_autosuspend() > is missing in the error path for bam_dmux_probe(). So add it. Please use devm_pm_runtime_enable(), which handles autosuspend. Also please provide details of the platform on which you have tested your patch. > > Fixes: 21a0ffd9b38c ("net: wwan: Add Qualcomm BAM-DMUX WWAN network driver") > Signed-off-by: Jinjie Ruan <ruanjinjie@xxxxxxxxxx> > --- > drivers/net/wwan/qcom_bam_dmux.c | 12 +++++++++--- > 1 file changed, 9 insertions(+), 3 deletions(-) > -- With best wishes Dmitry