Re: [PATCH 1/1] arm64: dts: qcom: qcs6490-rb3gen2: Add SD Card node

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 9/17/2024 7:08 PM, Dmitry Baryshkov wrote:
On Tue, Sep 17, 2024 at 02:36:30PM GMT, Sachin Gupta wrote:
Add SD Card node for Qualcomm qcs6490-rb3gen2 Board.

Consider adding mmc0 or mmc2 alias for the sdhc_2 node.

Thank you for your input. However, aliases you mentioned already exists in the sc7280.dtsi header file.

Signed-off-by: Sachin Gupta <quic_sachgupt@xxxxxxxxxxx>
---
  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 33 ++++++++++++++++++++
  1 file changed, 33 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
index 0d45662b8028..5df3167651ca 100644
--- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
+++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
@@ -716,9 +716,42 @@
  	status = "okay";
  };
+&sdc2_clk {
+	bias-disable;
+	drive-strength = <16>;
+};

Please move all pinctrl-related nodes below the PINCTRL comment.

Will update in next patch.
+
+&sdc2_cmd {
+	bias-pull-up;
+	drive-strength = <10>;
+};
+
+&sdc2_data {
+	bias-pull-up;
+	drive-strength = <10>;
+};

Thanks,
Sachin Gupta
+
>>
  &tlmm {
  	gpio-reserved-ranges = <32 2>, /* ADSP */
  			       <48 4>; /* NFC */
+
+	sd_cd: sd-cd-state {
+		pins = "gpio91";
+		function = "gpio";
+		bias-pull-up;
+	};

There is also a special PINCRTL_related TLMM imstance down the file,
move it to that node.

Will update in next patch.
  };
&uart5 {
--
2.17.1







[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux