On Wed, Sep 18, 2024 at 01:32:34AM +0200, Konrad Dybcio wrote:
> On 17.09.2024 5:00 PM, srinivas.kandagatla@xxxxxxxxxx wrote:
> > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> >
> > Trackpad HID device on some of the T14s Product Models 21N2ZC5PUS is
> > at I2C address 0x2c add this to be able to get it working on these laptops.
> >
> > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>
> > ---
> > Changes since v1:
> > - moved pinctrl to parent node so that pinctrl can be claimed globally.
> > &i2c0 {
> > clock-frequency = <400000>;
> >
> > + pinctrl-0 = <&tpad_default>;
> > + pinctrl-names = "default";
>
> You're dropping the QUP pins, please include them too (like in c630.dtsi)
And make sure to CC people that provide feedback on your patches when
respinning.
Johan
