On 16.09.2024 4:01 PM, Dmitry Baryshkov wrote: > On Mon, Sep 16, 2024 at 02:43:44PM GMT, Soutrik Mukhopadhyay wrote: >> Add device tree node for the DisplayPort controller >> and eDP PHY found on the Qualcomm SA8775P SoC. > > Not quite. You are also enabling it for the RIDE platforms, not just the > SA8775p SoC. (the patches should be split into soc and board parts) [...] >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + port@0 { >> + reg = <0>; >> + dpu_intf0_out: endpoint { Please add a newline between the last property and the subnode Konrad