> Thanks for the patch! However, I wouldn’t typically consider this > a fix, and I don’t think it would qualify for stable release > inclusion. Okay, I agree. > That said, I agree that a comment should be added back. The original > comment no longer fits as well as it did before. A more > appropriate comment would be: > > /* > * Do not enable interrupts by default to allow the system to enter > * low-power mode. The driver will explicitly enable interrupts when > * needed using enable_irq(). > */ > > Does it make sense? Frankly, I think this is too detailed, we can't have kernel driver 101 in each and every driver. But I will happily stand back if you insist because we are entering a bike-shedding area. My proposal would be: /* Keep interrupts disabled initially to allow for low-power modes */ Chose what you prefer! Happy hacking, Wolfram
Attachment:
signature.asc
Description: PGP signature
