On 13.09.2024 12:37 PM, Soutrik Mukhopadhyay wrote:
> In order to support different HW versions, introduce aux_cfg array
> to move v4 specific aux configuration settings.
>
> Signed-off-by: Soutrik Mukhopadhyay <quic_mukhopad@xxxxxxxxxxx>
> ---
> v2: Fixed review comments from Bjorn and Dmitry
> - Made aux_cfg array as const.
>
> ---
> drivers/phy/qualcomm/phy-qcom-edp.c | 37 ++++++++++++++++++-----------
> 1 file changed, 23 insertions(+), 14 deletions(-)
>
> diff --git a/drivers/phy/qualcomm/phy-qcom-edp.c b/drivers/phy/qualcomm/phy-qcom-edp.c
> index da2b32fb5b45..bcd5aced9e06 100644
> --- a/drivers/phy/qualcomm/phy-qcom-edp.c
> +++ b/drivers/phy/qualcomm/phy-qcom-edp.c
> @@ -90,6 +90,7 @@ struct phy_ver_ops {
>
> struct qcom_edp_phy_cfg {
> bool is_edp;
> + const u8 *aux_cfg;
> const struct qcom_edp_swing_pre_emph_cfg *swing_pre_emph_cfg;
> const struct phy_ver_ops *ver_ops;
> };
> @@ -186,11 +187,15 @@ static const struct qcom_edp_swing_pre_emph_cfg edp_phy_swing_pre_emph_cfg = {
> .pre_emphasis_hbr3_hbr2 = &edp_pre_emp_hbr2_hbr3,
> };
>
> +static const u8 edp_phy_aux_cfg_v4[10] = {
> + 0x00, 0x13, 0x24, 0x00, 0x0a, 0x26, 0x0a, 0x03, 0x37, 0x03
> +};
How about we only abstract the values that differ? It would seem like more
platforms reuse about half of these magic bytes
Konrad
