On Thu 02 Jun 08:50 PDT 2016, Mark Brown wrote: > On Thu, Jun 02, 2016 at 03:57:42PM +0100, Srinivas Kandagatla wrote: > > On 02/06/16 15:49, Mark Brown wrote: > > > > Why is this better than using a separate set of ops for the driver? > > > Am ok either way, it would be just few more lines for separate set of ops. > > It's more natural to use a separate set of ops, and we can optimise a > few things if we know the regulator is a fixed voltage one. In my view a fixed regulator is a thing that when you turn it on you get a predefined voltage, but iirc we actually need to send of a set-voltage request for the singly supported voltage on this ldo (which both implementations do today...). That's why I suggested Srini to do it this way, but maybe my interpretation of "fixed" is inaccurate? Regards, Bjorn -- To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html