On Tue, Sep 10, 2024 at 05:01:39PM GMT, Konrad Dybcio wrote: > From: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx> > > The current way of storing the configuration is very much > unmaintainable. Convert the data to use designated initializers to make > it easier both to understand and add/update the slice configuration > data. > > Signed-off-by: Konrad Dybcio <quic_kdybcio@xxxxxxxxxxx> > --- > I put this as RFC, since this makes the file gia-nor-mous.. However, I > don't think it's feasible to try and update these values based on > available information if the developer needs to count commas in the C89 > notation.. > --- > Changes in v2: > - Drop parameters that default to = 0 / = false (except .cache_mode, TBD) > - Fix up 8150 GPUHTW being out of style > - Trim leading zeroes in hex, make all hex uniformly lowercase > - Link to v1: https://lore.kernel.org/r/20240907-topic-llcc_unwrap-v1-1-cc6479a15ac3@xxxxxxxxxxx > --- > drivers/soc/qcom/llcc-qcom.c | 2644 +++++++++++++++++++++++++++++++++++++----- > 1 file changed, 2375 insertions(+), 269 deletions(-) > Manually checked several, but not all table entries. Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> -- With best wishes Dmitry