On Tue, Aug 27, 2024 at 11:18:10AM GMT, Stephen Boyd wrote: > Quoting Yan Zhen (2024-08-26 19:52:52) > > The devm_clk_hw_get_clk() function returns error pointers. > > It never returns NULL. Update the check accordingly. > > It can return NULL if the 'hw' pointer passed in is NULL. No, it will crash: WARN_ON_ONCE(dev != hw->core->dev); Furthermore, clk_hw_get_clk() also doesn't have NULL checks and will crash if NULL is passed as hw. struct clk *clk_hw_get_clk(struct clk_hw *hw, const char *con_id) { struct device *dev = hw->core->dev; -- With best wishes Dmitry