On Thu, Aug 22, 2024 at 11:14:57AM GMT, Sachin Gupta wrote:
> Add SD Card node for Qualcomm qcm6490-idp Board.
>
> Signed-off-by: Sachin Gupta <quic_sachgupt@xxxxxxxxxxx>
It doesn't look like this patch was tested, see below...
> ---
> arch/arm64/boot/dts/qcom/qcm6490-idp.dts | 27 ++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> index a0668f767e4b..8cfbb42af6a3 100644
> --- a/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> +++ b/arch/arm64/boot/dts/qcom/qcm6490-idp.dts
> @@ -641,6 +641,21 @@
> status = "okay";
> };
>
> +&sdc2_clk {
> + bias-disable;
> + drive-strength = <16>;
> +};
> +
> +&sdc2_cmd {
> + bias-pull-up;
> + drive-strength = <10>;
> +};
> +
> +&sdc2_data {
> + bias-pull-up;
> + drive-strength = <10>;
> +};
> +
> &sdhc_1 {
> non-removable;
> no-sd;
> @@ -652,6 +667,18 @@
> status = "okay";
> };
>
> +&sdhc_2 {
> + status = "okay";
> +
> + pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>, <&sd_cd>;
> + pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>, <&sd_cd>;
Please point me to the sd_cd definition that is going to be used here?
> +
> + vmmc-supply = <&vreg_l9c_2p96>;
> + vqmmc-supply = <&vreg_l6c_2p96>;
> +
> + cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
> +};
> +
> &tlmm {
> gpio-reserved-ranges = <32 2>, /* ADSP */
> <48 4>; /* NFC */
> --
> 2.17.1
>
--
With best wishes
Dmitry
