On Tue, Aug 20, 2024 at 11:27:01AM GMT, Varadarajan Narayanan wrote: > Add the bindings for the IPQ9574 CPR3 driver to the documentation. Bindings are for the hardware, not for the driver. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > Signed-off-by: Varadarajan Narayanan <quic_varada@xxxxxxxxxxx> > --- > v5: Add Reviewed-by > > v4: Change compatible string to cpr4 instead of cprh > Not adding Reviewed-By as compatible string changed I still see that it is being declared as compatible with qcom,cprh, while your hardware isn't CPRh, it's CPR4. > > v2: Constrained nvmem-cells and the other variant. > Removed unnecessary blank line. > --- > .../bindings/soc/qcom/qcom,cpr3.yaml | 35 +++++++++++++++++++ > 1 file changed, 35 insertions(+) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > index 2e6712aa1c58..c00373948901 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml > @@ -24,6 +24,7 @@ properties: > - const: qcom,cpr4 > - items: > - enum: > + - qcom,ipq9574-cpr4 > - qcom,msm8998-cprh > - qcom,sdm630-cprh > - const: qcom,cprh -- With best wishes Dmitry
