Quoting Neil Armstrong (2024-08-28 05:22:37) > On 28/08/2024 01:12, Stephen Boyd wrote: > > diff --git a/drivers/clk/qcom/gcc-sm8550.c b/drivers/clk/qcom/gcc-sm8550.c > > index 7944ddb4b47d..0244a05866b8 100644 > > --- a/drivers/clk/qcom/gcc-sm8550.c > > +++ b/drivers/clk/qcom/gcc-sm8550.c > > @@ -992,7 +992,7 @@ static struct clk_init_data gcc_qupv3_wrap2_s7_clk_src_init = { > > .parent_data = gcc_parent_data_0, > > .num_parents = ARRAY_SIZE(gcc_parent_data_0), > > .flags = CLK_SET_RATE_PARENT, > > - .ops = &clk_rcg2_shared_ops, > > + .ops = &clk_rcg2_ops, > > }; > > > > static struct clk_rcg2 gcc_qupv3_wrap2_s7_clk_src = { > > I think you missed gcc_qupv3_wrap2_s7_clk_src Nope. The diff header shows it is in gcc_qupv3_wrap2_s7_clk_src_init which is assigned to the gcc_qupv3_wrap2_s7_clk_src clk's hw.init pointer. .clkr.hw.init = &gcc_qupv3_wrap2_s7_clk_src_init,