On 8/28/2024 3:22 PM, Krzysztof Kozlowski wrote: > On Wed, Aug 28, 2024 at 11:05:10AM +0800, Jingyi Wang wrote: >> Document the components used to boot the ADSP, CDSP and GPDSP on the >> QCS8300 SoC. >> >> Co-developed-by: Xin Liu <quic_liuxin@xxxxxxxxxxx> >> Signed-off-by: Xin Liu <quic_liuxin@xxxxxxxxxxx> >> Signed-off-by: Jingyi Wang <quic_jingyw@xxxxxxxxxxx> >> --- >> .../bindings/remoteproc/qcom,sa8775p-pas.yaml | 22 +++++++++++++++++++ >> 1 file changed, 22 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >> index 7fe401a06805..44b070a17ca0 100644 >> --- a/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,sa8775p-pas.yaml >> @@ -16,6 +16,9 @@ description: >> properties: >> compatible: >> enum: >> + - qcom,qcs8300-adsp-pas >> + - qcom,qcs8300-cdsp-pas >> + - qcom,qcs8300-gpdsp-pas >> - qcom,sa8775p-adsp-pas >> - qcom,sa8775p-cdsp0-pas >> - qcom,sa8775p-cdsp1-pas >> @@ -64,6 +67,7 @@ allOf: >> properties: >> compatible: >> enum: >> + - qcom,qcs8300-adsp-pas >> - qcom,sa8775p-adsp-pas >> then: >> properties: >> @@ -75,6 +79,23 @@ allOf: >> items: >> - const: lcx >> - const: lmx >> + - if: >> + properties: >> + compatible: >> + enum: >> + - qcom,qcs8300-cdsp-pas > > This looks the same as sa8775p cdsp. Why new entry? > There is difference in power domain, sa8775p use nsp while qcs8300 use nsp0 > Best regards, > Krzysztof > Thanks, Jingyi