On 27/08/2024 17:16, Raviteja Laggyshetty wrote: > Add driver for the Qualcomm interconnect buses found in QCS8300 > based platforms. The topology consists of several NoCs that are > controlled by a remote processor that collects the aggregated > bandwidth for each master-slave pairs. > > + > +static struct qcom_icc_node *nspa_noc_nodes[] = { > + [MASTER_CDSP_NOC_CFG] = &qhm_nsp_noc_config, > + [MASTER_CDSP_PROC] = &qxm_nsp, > + [SLAVE_HCP_A] = &qns_hcp, > + [SLAVE_CDSP_MEM_NOC] = &qns_nsp_gemnoc, > + [SLAVE_SERVICE_NSP_NOC] = &service_nsp_noc, > +}; > + > +static struct qcom_icc_desc qcs8300_nspa_noc = { Sorry, but no. Start from scratch from MAINLINE driver so you won't repeat all the issues we fixed last years. Everything was fixed but then you send one more driver with exact same issues. EXACT. This applies to all QCS8300 submissions... actually this applies to all contributions to Linux kernel. Don't send your downstream code. Best regards, Krzysztof