On 27/08/2024 03:59, Thinh Nguyen wrote: > Hi Krzysztof, > > On Wed, Aug 14, 2024, Krzysztof Kozlowski wrote: >> Hi, >> >> The first ST patch depends on my fix: >> https://urldefense.com/v3/__https://lore.kernel.org/all/20240814093957.37940-2-krzysztof.kozlowski@xxxxxxxxxx/__;!!A4F2R9G_pg!eFzt54pYSEl8wrvrH7yQSwFRzbojnRSyelnYjxlY8RZaU6oZCVeui2f-DHQ0bk8Fdy6gvJoSWLeAPz2w_3F9ownOFLGUoyHd$ >> >> Series makes some code simplifications and cleanups. >> >> Best regards, >> Krzysztof >> >> --- >> Krzysztof Kozlowski (11): >> usb: dwc3: st: use scoped device node handling to simplify error paths >> usb: dwc3: st: simplify with dev_err_probe >> usb: dwc3: st: simplify pdev->dev usage >> usb: dwc3: imx8mp: simplify with devm_clk_get_enabled >> usb: dwc3: imx8mp: simplify with dev_err_probe >> usb: dwc3: imx8mp: use scoped device node handling to simplify error paths >> usb: dwc3: qcom: use scoped device node handling to simplify error paths >> usb: dwc3: qcom: simplify with devm_platform_ioremap_resource >> usb: dwc3: rtk: use scoped device node handling to simplify error paths >> usb: dwc3: rtk: return directly and simplify with devm_platform_ioremap_resource >> usb: dwc3: xilinx: simplify with dev_err_probe >> >> drivers/usb/dwc3/dwc3-imx8mp.c | 66 ++++++++++++------------------------------ >> drivers/usb/dwc3/dwc3-qcom.c | 16 ++++------ >> drivers/usb/dwc3/dwc3-rtk.c | 52 ++++++++++----------------------- >> drivers/usb/dwc3/dwc3-st.c | 38 +++++++++++------------- >> drivers/usb/dwc3/dwc3-xilinx.c | 7 ++--- >> 5 files changed, 58 insertions(+), 121 deletions(-) >> --- >> base-commit: 64b429eaf21be888cc83e9013e25897d5fb03a75 >> change-id: 20240814-b4-cleanup-h-of-node-put-usb-93fadfc77d33 >> >> Best regards, >> -- >> Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> >> > > Thanks for the cleanup! > > I wish the mixed declarations in between statements for some of the > scoped device node handling can be changed. Bugs me a little with how > I'm used to parse the old standard with my eyes, but it's not a big > issue. Maybe this will be helpful: https://lore.kernel.org/all/CAHk-=wicfvWPuRVDG5R1mZSxD8Xg=-0nLOiHay2T_UJ0yDX42g@xxxxxxxxxxxxxx/ https://lore.kernel.org/all/CAHk-=wgRHiV5VSxtfXA4S6aLUmcQYEuB67u3BJPJPtuESs1JyA@xxxxxxxxxxxxxx/ https://lore.kernel.org/all/CAHk-=whvOGL3aNhtps0YksGtzvaob_bvZpbaTcVEqGwNMxB6xg@xxxxxxxxxxxxxx/ and finally it will reach documentation (although it focuses on unwinding process to be specific - "When the unwind order ..."): https://lore.kernel.org/all/171175585714.2192972.12661675876300167762.stgit@xxxxxxxxxxxxxxxxxxxxxxxxx/ Best regards, Krzysztof
