On 23/08/2024 22:33, Stephen Boyd wrote:
Quoting neil.armstrong@xxxxxxxxxx (2024-08-21 08:44:00)
Hi,
On 20/08/2024 01:36, Stephen Boyd wrote:
Amit Pundir reported[1] that a recent commit 01a0a6cc8cfd ("clk: qcom:
Park shared RCGs upon registration") broke USB and audio on sm8550-hdk.
These two patches fix the issue by skipping the parking bit of the
shared RCGs for devices that can't run so slow.
[1] https://lore.kernel.org/CAMi1Hd1KQBE4kKUdAn8E5FV+BiKzuv+8FoyWQrrTHPDoYTuhgA@xxxxxxxxxxxxxx/
Stephen Boyd (2):
clk: qcom: gcc-sm8550: Don't use parking clk_ops for QUPs
clk: qcom: gcc-sm8550: Don't park the USB RCG at registration time
drivers/clk/qcom/clk-rcg.h | 1 +
drivers/clk/qcom/clk-rcg2.c | 30 +++++++++++++++++++
drivers/clk/qcom/gcc-sm8550.c | 54 +++++++++++++++++------------------
3 files changed, 58 insertions(+), 27 deletions(-)
base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
I'm pretty sure sm8450 & sm8650 (and probably other SoCs) could be also affected, could you check ?
Does someone have the hardware to test? It looks like sm8450 isn't using
the shared ops, but sm8650 is, likely incorrectly.
I can't reproduce the uart issue on 8650, I'll try moving some dependencies (CLK, ICC, ..) as modules.
Bryan reproduced it on X1, and he posted a patch.
Neil
