Hi Md, kernel test robot noticed the following build warnings: [auto build test WARNING on mtd/nand/next] [also build test WARNING on broonie-spi/for-next robh/for-next linus/master v6.11-rc4 next-20240820] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Md-Sadre-Alam/spi-dt-bindings-Introduce-qcom-spi-qpic-snand/20240820-184732 base: https://git.kernel.org/pub/scm/linux/kernel/git/mtd/linux.git nand/next patch link: https://lore.kernel.org/r/20240820104239.1774600-7-quic_mdalam%40quicinc.com patch subject: [PATCH v8 6/8] spi: spi-qpic: add driver for QCOM SPI NAND flash Interface config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20240821/202408210853.PGPCGquw-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 14.1.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240821/202408210853.PGPCGquw-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202408210853.PGPCGquw-lkp@xxxxxxxxx/ All warnings (new ones prefixed by >>): drivers/spi/spi-qpic-snand.c: In function 'qcom_spi_ecc_init_ctx_pipelined': >> drivers/spi/spi-qpic-snand.c:248:28: warning: variable 'strength' set but not used [-Wunused-but-set-variable] 248 | int step_size = 0, strength = 0; | ^~~~~~~~ >> drivers/spi/spi-qpic-snand.c:248:13: warning: variable 'step_size' set but not used [-Wunused-but-set-variable] 248 | int step_size = 0, strength = 0; | ^~~~~~~~~ drivers/spi/spi-qpic-snand.c: In function 'qcom_spi_write_page': drivers/spi/spi-qpic-snand.c:1259:30: warning: variable 's_op' set but not used [-Wunused-but-set-variable] 1259 | struct qpic_snand_op s_op = {}; | ^~~~ drivers/spi/spi-qpic-snand.c: At top level: drivers/spi/spi-qpic-snand.c:1630:19: error: initialization of 'int (*)(struct platform_device *)' from incompatible pointer type 'void (*)(struct platform_device *)' [-Wincompatible-pointer-types] 1630 | .remove = qcom_spi_remove, | ^~~~~~~~~~~~~~~ drivers/spi/spi-qpic-snand.c:1630:19: note: (near initialization for 'qcom_spi_driver.remove') vim +/strength +248 drivers/spi/spi-qpic-snand.c 240 241 static int qcom_spi_ecc_init_ctx_pipelined(struct nand_device *nand) 242 { 243 struct qcom_nand_controller *snandc = nand_to_qcom_snand(nand); 244 struct nand_ecc_props *conf = &nand->ecc.ctx.conf; 245 struct nand_ecc_props *reqs = &nand->ecc.requirements; 246 struct nand_ecc_props *user = &nand->ecc.user_conf; 247 struct mtd_info *mtd = nanddev_to_mtd(nand); > 248 int step_size = 0, strength = 0; 249 int cwperpage, bad_block_byte; 250 struct qpic_ecc *ecc_cfg; 251 252 cwperpage = mtd->writesize / NANDC_STEP_SIZE; 253 snandc->qspi->num_cw = cwperpage; 254 255 ecc_cfg = kzalloc(sizeof(*ecc_cfg), GFP_KERNEL); 256 if (!ecc_cfg) 257 return -ENOMEM; 258 snandc->qspi->oob_buf = kzalloc(mtd->writesize + mtd->oobsize, 259 GFP_KERNEL); 260 if (!snandc->qspi->oob_buf) 261 return -ENOMEM; 262 263 memset(snandc->qspi->oob_buf, 0xff, mtd->writesize + mtd->oobsize); 264 265 nand->ecc.ctx.priv = ecc_cfg; 266 snandc->qspi->mtd = mtd; 267 268 if (user->step_size && user->strength) { 269 step_size = user->step_size; 270 strength = user->strength; 271 } else if (reqs->step_size && reqs->strength) { 272 step_size = reqs->step_size; 273 strength = reqs->strength; 274 } 275 276 ecc_cfg->ecc_bytes_hw = 7; 277 ecc_cfg->spare_bytes = 4; 278 ecc_cfg->bbm_size = 1; 279 ecc_cfg->bch_enabled = true; 280 ecc_cfg->bytes = ecc_cfg->ecc_bytes_hw + ecc_cfg->spare_bytes + ecc_cfg->bbm_size; 281 282 ecc_cfg->steps = 4; 283 ecc_cfg->strength = 4; 284 ecc_cfg->step_size = 512; 285 ecc_cfg->cw_data = 516; 286 ecc_cfg->cw_size = ecc_cfg->cw_data + ecc_cfg->bytes; 287 bad_block_byte = mtd->writesize - ecc_cfg->cw_size * (cwperpage - 1) + 1; 288 289 mtd_set_ooblayout(mtd, &qcom_spi_ooblayout); 290 291 ecc_cfg->cfg0 = FIELD_PREP(CW_PER_PAGE_MASK, (cwperpage - 1)) | 292 FIELD_PREP(UD_SIZE_BYTES_MASK, ecc_cfg->cw_data) | 293 FIELD_PREP(DISABLE_STATUS_AFTER_WRITE, 1) | 294 FIELD_PREP(NUM_ADDR_CYCLES_MASK, 3) | 295 FIELD_PREP(ECC_PARITY_SIZE_BYTES_RS, ecc_cfg->ecc_bytes_hw) | 296 FIELD_PREP(STATUS_BFR_READ, 0) | 297 FIELD_PREP(SET_RD_MODE_AFTER_STATUS, 1) | 298 FIELD_PREP(SPARE_SIZE_BYTES_MASK, ecc_cfg->spare_bytes); 299 300 ecc_cfg->cfg1 = FIELD_PREP(NAND_RECOVERY_CYCLES_MASK, 0) | 301 FIELD_PREP(CS_ACTIVE_BSY, 0) | 302 FIELD_PREP(BAD_BLOCK_BYTE_NUM_MASK, bad_block_byte) | 303 FIELD_PREP(BAD_BLOCK_IN_SPARE_AREA, 0) | 304 FIELD_PREP(WR_RD_BSY_GAP_MASK, 20) | 305 FIELD_PREP(WIDE_FLASH, 0) | 306 FIELD_PREP(ENABLE_BCH_ECC, ecc_cfg->bch_enabled); 307 308 ecc_cfg->cfg0_raw = FIELD_PREP(CW_PER_PAGE_MASK, (cwperpage - 1)) | 309 FIELD_PREP(NUM_ADDR_CYCLES_MASK, 3) | 310 FIELD_PREP(UD_SIZE_BYTES_MASK, ecc_cfg->cw_size) | 311 FIELD_PREP(SPARE_SIZE_BYTES_MASK, 0); 312 313 ecc_cfg->cfg1_raw = FIELD_PREP(NAND_RECOVERY_CYCLES_MASK, 0) | 314 FIELD_PREP(CS_ACTIVE_BSY, 0) | 315 FIELD_PREP(BAD_BLOCK_BYTE_NUM_MASK, 17) | 316 FIELD_PREP(BAD_BLOCK_IN_SPARE_AREA, 1) | 317 FIELD_PREP(WR_RD_BSY_GAP_MASK, 20) | 318 FIELD_PREP(WIDE_FLASH, 0) | 319 FIELD_PREP(DEV0_CFG1_ECC_DISABLE, 1); 320 321 ecc_cfg->ecc_bch_cfg = FIELD_PREP(ECC_CFG_ECC_DISABLE, !ecc_cfg->bch_enabled) | 322 FIELD_PREP(ECC_SW_RESET, 0) | 323 FIELD_PREP(ECC_NUM_DATA_BYTES_MASK, ecc_cfg->cw_data) | 324 FIELD_PREP(ECC_FORCE_CLK_OPEN, 1) | 325 FIELD_PREP(ECC_MODE_MASK, 0) | 326 FIELD_PREP(ECC_PARITY_SIZE_BYTES_BCH_MASK, ecc_cfg->ecc_bytes_hw); 327 328 ecc_cfg->ecc_buf_cfg = 0x203 << NUM_STEPS; 329 ecc_cfg->clrflashstatus = FS_READY_BSY_N; 330 ecc_cfg->clrreadstatus = 0xc0; 331 332 conf->step_size = ecc_cfg->step_size; 333 conf->strength = ecc_cfg->strength; 334 335 snandc->regs->erased_cw_detect_cfg_clr = cpu_to_le32(CLR_ERASED_PAGE_DET); 336 snandc->regs->erased_cw_detect_cfg_set = cpu_to_le32(SET_ERASED_PAGE_DET); 337 338 dev_dbg(snandc->dev, "ECC strength: %u bits per %u bytes\n", 339 ecc_cfg->strength, ecc_cfg->step_size); 340 341 return 0; 342 } 343 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
