On 20/08/2024 11:15, Vladimir Zapolskiy wrote: > Hi Richard, > ... >> + >> + clocks: > > Please add > > minItems: 22 > >> + maxItems: 22> + >> + clock-names: >> + items: >> + - const: camnoc_axi >> + - const: cpas_ahb >> + - const: csi0 >> + - const: csi1 >> + - const: csi2 >> + - const: csiphy0 >> + - const: csiphy0_timer >> + - const: csiphy1 >> + - const: csiphy1_timer >> + - const: csiphy2 >> + - const: csiphy2_timer >> + - const: gcc_camera_ahb >> + - const: gcc_camera_axi >> + - const: soc_ahb >> + - const: vfe0_axi >> + - const: vfe0 >> + - const: vfe0_cphy_rx >> + - const: vfe1_axi >> + - const: vfe1 >> + - const: vfe1_cphy_rx >> + - const: vfe_lite >> + - const: vfe_lite_cphy_rx >> + >> + interrupts: > > Please add > > minItems: 9 > >> + maxItems: 9 >> + >> + interrupt-names: >> + items: >> + - const: csid0 >> + - const: csid1 >> + - const: csid2 >> + - const: csiphy0 >> + - const: csiphy1 >> + - const: csiphy2 >> + - const: vfe0 >> + - const: vfe1 >> + - const: vfe_lite >> + >> + iommus: > > Please add > > minItems: 4> >> + maxItems: 4 >> + >> + power-domains: >> + items: >> + - description: IFE0 GDSC - Image Front End, Global Distributed Switch Controller. >> + - description: IFE1 GDSC - Image Front End, Global Distributed Switch Controller. >> + - description: Titan Top GDSC - Titan ISP Block, Global Distributed Switch Controller. >> + >> + power-domain-names: >> + items: >> + - const: ife0 >> + - const: ife1 >> + - const: top >> + >> + ports: >> + $ref: /schemas/graph.yaml#/properties/ports >> + >> + description: >> + CSI input ports. >> + >> + properties: >> + port@0: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: >> + Input port for receiving CSI data from CSIPHY0. >> + >> + properties: >> + endpoint: >> + $ref: video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + properties: >> + clock-lanes: >> + maxItems: 1 >> + >> + data-lanes: >> + minItems: 1 >> + maxItems: 4 >> + >> + required: >> + - clock-lanes >> + - data-lanes >> + >> + port@1: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: >> + Input port for receiving CSI data from CSIPHY1. >> + >> + properties: >> + endpoint: >> + $ref: video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + properties: >> + clock-lanes: >> + maxItems: 1 >> + >> + data-lanes: >> + minItems: 1 >> + maxItems: 4 >> + >> + required: >> + - clock-lanes >> + - data-lanes >> + >> + port@2: >> + $ref: /schemas/graph.yaml#/$defs/port-base >> + unevaluatedProperties: false >> + description: >> + Input port for receiving CSI data from CSIPHY2. >> + >> + properties: >> + endpoint: >> + $ref: video-interfaces.yaml# >> + unevaluatedProperties: false >> + >> + properties: >> + clock-lanes: >> + maxItems: 1 >> + >> + data-lanes: >> + minItems: 1 >> + maxItems: 4 >> + >> + required: >> + - clock-lanes >> + - data-lanes >> + >> + reg: > > Please add > > minItems: 9 None of above are necessary and this contradicts review we give to drop these... Best regards, Krzysztof
