On 18/08/2024 23:50, Jan Petrous (OSS) wrote: > Add basic description for DWMAC ethernet IP on NXP S32G2xx, S32G3xx > and S32R45 automotive series SoCs. Fix your email threading. b4 handle everything correctly, so start using it. > > Signed-off-by: Jan Petrous (OSS) <jan.petrous@xxxxxxxxxxx> > --- > .../bindings/net/nxp,s32cc-dwmac.yaml | 127 ++++++++++++++++++ > .../devicetree/bindings/net/snps,dwmac.yaml | 1 + > 2 files changed, 128 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml > > diff --git a/Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml b/Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml > new file mode 100644 > index 000000000000..443ad918a9a5 > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/nxp,s32cc-dwmac.yaml Filename based on compatible, so what does "cc" stand for? > @@ -0,0 +1,127 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +# Copyright 2021-2024 NXP > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/net/nxp,s32cc-dwmac.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP S32G2xx/S32G3xx/S32R45 GMAC ethernet controller > + > +maintainers: > + - Jan Petrous (OSS) <jan.petrous@xxxxxxxxxxx> > + > +description: | Do not need '|' unless you need to preserve formatting. > + This device is a platform glue layer for stmmac. Drop description of driver and instead describe the hardware. > + Please see snps,dwmac.yaml for the other unchanged properties. > + > +properties: > + compatible: > + enum: > + - nxp,s32g2-dwmac > + - nxp,s32g3-dwmac > + - nxp,s32r45-dwmac > + > + reg: > + items: > + - description: Main GMAC registers > + - description: GMAC PHY mode control register > + > + interrupts: > + description: Common GMAC interrupt No, instead maxItems: 1 > + > + interrupt-names: > + const: macirq > + > + clocks: > + items: > + - description: Main GMAC clock > + - description: Transmit clock > + - description: Receive clock > + - description: PTP reference clock > + > + clock-names: > + items: > + - const: stmmaceth > + - const: tx > + - const: rx > + - const: ptp_ref > + > +required: > + - compatible > + - reg > + - interrupts > + - interrupt-names > + - clocks > + - clock-names > + - phy-mode Drop, snps,dwmac requires this. > + > +allOf: > + - $ref: snps,dwmac.yaml# > + > +unevaluatedProperties: false > + > +examples: > + - | > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/interrupt-controller/irq.h> > + #include <dt-bindings/phy/phy.h> > + bus { > + #address-cells = <2>; > + #size-cells = <2>; > + > + ethernet@4033c000 { > + compatible = "nxp,s32cc-dwmac"; > + reg = <0x0 0x4033c000 0x0 0x2000>, /* gmac IP */ > + <0x0 0x4007c004 0x0 0x4>; /* GMAC_0_CTRL_STS */ > + interrupt-parent = <&gic>; > + interrupts = <GIC_SPI 57 IRQ_TYPE_LEVEL_HIGH>; > + interrupt-names = "macirq"; > + snps,mtl-rx-config = <&mtl_rx_setup>; > + snps,mtl-tx-config = <&mtl_tx_setup>; > + clocks = <&clks 24>, <&clks 17>, <&clks 16>, <&clks 15>; > + clock-names = "stmmaceth", "tx", "rx", "ptp_ref"; > + phy-mode = "rgmii-id"; > + phy-handle = <&phy0>; > + > + mtl_rx_setup: rx-queues-config { > + snps,rx-queues-to-use = <5>; > + > + queue0 { > + }; > + queue1 { > + }; Why listing empty nodes? Best regards, Krzysztof
