On Fri, Aug 16, 2024 at 03:50:20PM -0700, Bjorn Andersson wrote: > On Wed, Jul 10, 2024 at 08:25:20AM +0900, Kyoungrul Kim wrote: > > if the user sets use_mcq_mode to 0, the host will try to activate the > > lsdb mode unconditionally even when the lsdbs of device hci cap is 1. so > > it makes timeout cmds and fail to device probing. > > > > To prevent that problem. check the lsdbs cap when mcq is not supported > > case. > > > > Signed-off-by: k831.kim <k831.kim@xxxxxxxxxxx> > > --- > > Changes to v1: Fix wrong bit of lsdb support. > > Changes to v2: Fix extra space and wrong commit messeage. > > Changes to v3: Close missing parenthesis and fix grammatical error. > > This causes the probe of the UFSHCD in Qualcomm SM8550 MTP to fail with > -EINVAL. > > [ 6.132937] ufshcd-qcom 1d84000.ufs: Adding to iommu group 4 > [ 6.142509] ufshcd-qcom 1d84000.ufs: freq-table-hz property not specified > [ 6.149843] ufshcd-qcom 1d84000.ufs: ufshcd_populate_vreg: Unable to find vccq2-supply regulator, assuming enabled > [ 6.209794] ufshcd-qcom 1d84000.ufs: ufshcd_init: failed to initialize (legacy doorbell mode not supported) > [ 6.226571] ufshcd-qcom 1d84000.ufs: error -EINVAL: Initialization failed with error -22 > [ 6.348770] ufshcd-qcom 1d84000.ufs: error -EINVAL: ufshcd_pltfrm_init() failed > [ 6.363203] ufshcd-qcom 1d84000.ufs: probe with driver ufshcd-qcom failed with error -22 > > #regzbot introduced: 0c60eb0cc320 > #regzbot title: scsi: ufs: Qualcomm SM8550 MTP UFSHCD probe failing > Fix got merged for v6.11: https://lore.kernel.org/linux-scsi/20240816-ufs-bug-fix-v3-0-e6fe0e18e2a3@xxxxxxxxxx/ - Mani -- மணிவண்ணன் சதாசிவம்
