On 15/08/2024 12:42, Marcus Glocker wrote:
> Add the UFS Host Controller node. This was basically copied from the
> arch/arm64/boot/dts/qcom/sc7180.dtsi file.
>
> Signed-off-by: Marcus Glocker <marcus@xxxxxxxxx>
> +
> + ufs_mem_phy: phy@1d87000 {
> + compatible = "qcom,x1e80100-qmp-ufs-phy";
> + reg = <0 0x01d87000 0 0x1000>;
> + clocks = <&rpmhcc RPMH_CXO_CLK>,
> + <&gcc GCC_UFS_PHY_PHY_AUX_CLK>;
> + clock-names = "ref",
> + "ref_aux",
> + "qref";
One does not match the other.
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
