On 13/08/2024 16:09, Konrad Dybcio wrote: > On 10.08.2024 2:48 PM, Krzysztof Kozlowski wrote: >> On 09/08/2024 15:18, Konrad Dybcio wrote: >>> X1E80100 has a multiport controller with 2 HS (eUSB) and 2 SS PHYs >>> attached to it. It's commonly used for USB-A ports and internally >>> routed devices. Configure it to support such functionality. >>> >>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx> >> >> You have from and SoB mismatch. This was sent some odd way, because both >> b4 and git send-email would produce correct From field. > > So, I'm: > > - sending from @kernel because it has a good email server > - authoring from @quicinc because that's my employer > - sending some older @linaro patches because I made them before > switching jobs and it's only fair to do so like this > (and I sometimes reply from @gmail because thunderbird works funnily) This is all fine, but you created commit with one identity and signed off with other. That's not fine. > > I noticed locally that if you switch emails & edit author too often, git > gets confused and `git show` Author: / `git send` From: don't get updated > properly, but if you do git format-patch, the resulting file has what you > would expect.. > > Should I resend this? Yes, so there will be proper From field with proper author matching at least one SoBs. Best regards, Krzysztof
