On 7/11/2024 7:12 PM, Krzysztof Kozlowski wrote:
On 11/07/2024 13:08, Depeng Shao wrote:
+
+static void csid_subdev_init(struct csid_device *csid)
+{
+ csid->testgen.modes = csid_testgen_modes;
+ csid->testgen.nmodes = CSID_PAYLOAD_MODE_NUM_SUPPORTED_GEN2;
+}
+
+const struct csid_hw_ops csid_ops_gen3 = {
Isn't there a warning here?
+ .configure_stream = csid_configure_stream,
+ .configure_testgen_pattern = csid_configure_testgen_pattern,
+ .hw_version = csid_hw_version,
+ .isr = csid_isr,
+ .reset = csid_reset,
+ .src_pad_code = csid_src_pad_code,
+ .subdev_init = csid_subdev_init,
+};
Your patchset does not apply at all. Tried v6.9, v6.10, next. I see some
dependency above, but that means no one can test it and no one can apply it.
Fix the warnings, I cannot verify it but I am sure you have them.
My code base is next master branch, do you mean the 'declared and not
used' warning? I don't see this warning with below two version compiler
even though I just pick this patch and pull the code the latest version.
But it indeed have this issue, these structures are declared and will be
used later in "media: qcom: camss: Add sm8550 resources" patch, will
think about how to avoid this.
aarch64-linux-gnu-gcc (Ubuntu/Linaro 7.5.0-3ubuntu1~18.04) 7.5.0
aarch64-linux-gnu-gcc (Ubuntu 11.4.0-1ubuntu1~22.04) 11.4.0
That's some old compilers... I am talking about recent GCC, recent clang
and of course W=1.
Hi Krzysztof,
I'm preparing the next version patches, then I find it is hard to avoid
such warning if only apply current patch, since this will be used in the
below patch, it will be in structures csid_res_8550 -> sm8550_resources
-> camss_dt_match, so I need to add all csid_res_8550, sm8550_resources,
camss_dt_match into this patch if I want to avoid the compile warning,
then I also need to add compatible info for it to avoid sm8550_resources
has unused variable warning, but the sm8550_resources structure also
need to add other items to make it complete, then the driver will be
incomplete but can be probed with this patch.
{ .compatible = "qcom,sm8550-camss", .data = &sm8550_resources },
https://lore.kernel.org/all/20240709160656.31146-14-quic_depengs@xxxxxxxxxxx/
Could you please share some suggestions?
Best regards,
Krzysztof
Thanks,
Depeng
