Re: [PATCH V3] dt-bindings: clock: qcom: Remove required-opps from required list on SM8650

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 7/31/2024 11:57 AM, Krzysztof Kozlowski wrote:
On 30/07/2024 05:45, Jagadeesh Kona wrote:
-
  properties:
    compatible:
      enum:
@@ -57,7 +54,24 @@ required:
    - compatible
    - clocks
    - power-domains
-  - required-opps
+
+allOf:
+  - $ref: qcom,gcc.yaml#
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - qcom,sc8280xp-camcc
+              - qcom,sm8450-camcc
+              - qcom,sm8550-camcc
+              - qcom,x1e80100-camcc
+    then:
+      required:
+        - required-opps
+    else:
+      properties:
+        required-opps: false


Why would required-opps be invalid for SM8650? What if we want some
higher opp for some reason? The point of v1 and v2 was oonly to require
required-opps on certain variants, not to disallow it in other cases.


Thanks Krzysztof for your review.

Yes, agree, will drop the else part in next series.

Thanks,
Jagadeesh

Best regards,
Krzysztof





[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux