On Tue, Jul 30, 2024 at 1:35 PM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > > On Mon, Jul 29, 2024 at 2:49 PM Johan Hovold <johan@xxxxxxxxxx> wrote: > > > > On Mon, Jul 29, 2024 at 02:35:39PM +0200, Bartosz Golaszewski wrote: > > > > > On Mon, Jul 29, 2024 at 11:58 AM Johan Hovold <johan+linaro@xxxxxxxxxx> wrote: > > > > > > > > > > > > This reverts commit 6612103ec35af6058bb85ab24dae28e119b3c055. > > > > > > > > > > > > Using the "TZ allocator" for qcseecom breaks efivars on machines like > > > > > > the Lenovo ThinkPad X13s and x1e80100 CRD: > > > > > > > > > > > > qcom_scm firmware:scm: qseecom: scm call failed with error -22 > > > > > How do you reproduce this on x1e? > > > > Just boot 6.11-rc1 and you should see the above error (and there are no > > variables under /sys/firmware/efi/efivars/). > > > > Johan > > I'm trying to figure out what the difference is with and without > tzmem. Surprisingly the physical address passed down to the SCM call > is actually the same in both cases. > > I figured that maybe using different struct device for the underlying > dma_alloc_coherent() would be the culprit but I checked and no. > > I'm still on it. > > Bart Nevermind, I found the culprit. I will send a fix proposal shortly. Bart
