On 7/28/2024 7:41 AM, Gokul Sriram P wrote:
On 7/18/2024 9:55 PM, Jeffrey Hugo wrote:
On 7/18/2024 12:13 AM, Gokul Sriram Palanisamy wrote:
diff --git a/include/linux/mhi.h b/include/linux/mhi.h
index c0c9bfc28e4a..2f90de8616f3 100644
--- a/include/linux/mhi.h
+++ b/include/linux/mhi.h
@@ -839,4 +839,12 @@ int mhi_get_channel_doorbell_offset(struct
mhi_controller *mhi_cntrl, u32 *chdb_
* @mhi_cntrl: MHI controller
*/
void mhi_debug_reg_dump(struct mhi_controller *mhi_cntrl);
+
+/**
+ * mhi_scan_rddm_cookie - Look for supplied cookie value in the BHI
debug
+ * registers set by device to indicate rddm readiness for debugging
purposes.
+ * @mhi_cntrl: MHI controller
+ * @cookie: cookie/pattern value to match
+ */
+bool mhi_scan_rddm_cookie(struct mhi_controller *mhi_cntrl, u32
cookie);
#endif /* _MHI_H_ */
NACK. This is not used.
mhi_debug_reg_dump - this is added in 3 places, mhi_fw_load_bhi( ),
mhi_fw_load_bhie( ) and mhi_download_rddm_image( ) to print error codes
on failure scenarios.
What do you mean by not used?
You add an API to other drivers, mhi_scan_rddm_cookie(), but no code
ever calls it. This entire patch is useless as all it does is add dead
code.
