On 22.07.2024 2:47 PM, Nikita Travkin wrote:
> From: Anton Bambura <jenneron@xxxxxxxxxxxxxxxx>
>
> Add initial device-tree for Lenovo A6000 (wt86518) and Lenovo A6010
> (wt86528), which are MSM8916-based devices. These devices are quite
> similar, so some configuration is shared in msm8916-wingtech-wt865x8.dtsi.
[...]
> +/ {
> + model = "Lenovo A6000 (Wingtech WT86518)";
> + compatible = "wingtech,wt86518", "qcom,msm8916";
> + chassis-type = "handset";
> +
> + speaker_amp: audio-amplifier {
> + compatible = "awinic,aw8738";
> +
> + pinctrl-names = "default";
> + pinctrl-0 = <&spk_ext_pa_default>;
flip
[...]
> +&sound {
> + model = "wt88047";
> + widgets =
> + "Speaker", "Speaker",
> + "Headphone", "Headphones";
Please don't start a new line for this (same below)
> + pin-switches = "Speaker", "Headphones";
> + audio-routing =
> + "Speaker", "Speaker Amp OUT",
> + "Speaker Amp IN", "HPH_R",
[...]
> + /* left AW8736 */
> + speaker_amp_left: audio-amplifier-left {
> + compatible = "awinic,aw8738";
Should this get a new compatible (with a fallback if sw-compatible)?
> +
> + pinctrl-0 = <&spk_ext_pa_left_default>;
> + pinctrl-names = "default";
> +
> + mode-gpios = <&tlmm 119 GPIO_ACTIVE_HIGH>;
> + sound-name-prefix = "Speaker Amp L";
> + awinic,mode = <3>;
> + };
> +
> + /* right AW8736 */
> + speaker_amp_right: audio-amplifier-right {
> + compatible = "awinic,aw8738";
ditto
Konrad
