On Thu, Jul 18, 2024 at 5:31 AM Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxx> wrote: > > On Wed, Jul 17, 2024 at 06:09:29PM GMT, Rob Clark wrote: > > On Wed, Jul 17, 2024 at 5:19 PM Doug Anderson <dianders@xxxxxxxxxxxx> wrote: > > > > > > Hi, > > > > > > On Wed, Jul 17, 2024 at 2:58 PM Rob Clark <robdclark@xxxxxxxxx> wrote: > > > > > > > > From: Rob Clark <robdclark@xxxxxxxxxxxx> > > > > > > > > Just a guess on the panel timings, but they appear to work. > > > > > > > > Signed-off-by: Rob Clark <robdclark@xxxxxxxxxxxx> > > > > --- > > > > This adds the panel I have on my lenovo yoga slim 7x laptop. I couldn't > > > > find any datasheet so timings is just a guess. But AFAICT everything > > > > works fine. > > > > > > > > drivers/gpu/drm/panel/panel-edp.c | 2 ++ > > > > 1 file changed, 2 insertions(+) > > > > > > Given that this is a Samsung ATNA<mumble>, is there any chance it's an > > > OLED panel? Should it be supported with the Samsung OLED panel driver > > > like this: > > > > > > https://lore.kernel.org/r/20240715-x1e80100-crd-backlight-v2-0-31b7f2f658a3@xxxxxxxxxx > > > > it is an OLED panel, and I did see that patchset and thought that > > samsung panel driver would work. But changing the compat string on > > the yoga dts only gave me a black screen (and I didn't see any of the > > other mentioned problems with bl control or dpms with panel-edp). So > > :shrug:? It could be I overlooked something else, but it _seems_ like > > panel-edp is fine for this panel. Plus, it would avoid awkwardness if > > it turned out there were other non-samsung 2nd sources, but so far > > with a sample size of two 100% of these laptops have the same panel > > ;-) > > > > But that was the reason for posting this as an RFC. I was hoping > > someone had some hint about where to find datasheets (my google'ing > > was not successful), etc. > > Panelook has a datasheet for ATNA45DC01. It's behind a 'register new > business email' paywall. but it does not appear to have ATNA45DC02 fwiw, edid: ---------------- edid-decode (hex): 00 ff ff ff ff ff ff 00 4c 83 89 41 00 00 00 00 00 21 01 04 b5 1f 14 78 02 0b d1 af 51 3d b6 23 0b 50 54 00 00 00 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 1e cc 80 50 b0 30 10 74 08 20 88 00 38 c3 10 00 00 1b 1e cc 80 50 b0 30 50 70 08 20 88 00 38 c3 10 00 00 1b 00 00 00 fe 00 53 44 43 20 20 20 20 20 20 20 20 20 20 00 00 00 fe 00 41 54 4e 41 34 35 44 43 30 32 2d 30 20 01 06 02 03 0f 00 e3 05 80 00 e6 06 05 01 8a 6a 02 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 9c ---------------- Block 0, Base EDID: EDID Structure Version & Revision: 1.4 Vendor & Product Identification: Manufacturer: SDC Model: 16777 Made in: 2023 Basic Display Parameters & Features: Digital display Bits per primary color channel: 10 DisplayPort interface Maximum image size: 31 cm x 20 cm Gamma: 2.20 Supported color formats: RGB 4:4:4 First detailed timing includes the native pixel format and preferred refresh rate Color Characteristics: Red : 0.6835, 0.3164 Green: 0.2402, 0.7138 Blue : 0.1396, 0.0439 White: 0.3125, 0.3291 Established Timings I & II: none Standard Timings: none Detailed Timing Descriptors: DTD 1: 2944x1840 59.999173 Hz 16:10 172.798 kHz 522.540000 MHz (312 mm x 195 mm) Hfront 8 Hsync 32 Hback 40 Hpol P Vfront 8 Vsync 8 Vback 1024 Vpol N DTD 2: 2944x1840 89.998760 Hz 16:10 172.798 kHz 522.540000 MHz (312 mm x 195 mm) Hfront 8 Hsync 32 Hback 40 Hpol P Vfront 8 Vsync 8 Vback 64 Vpol N Alphanumeric Data String: 'SDC ' Alphanumeric Data String: 'ATNA45DC02-0 ' Extension blocks: 1 Checksum: 0x06 ---------------- Block 1, CTA-861 Extension Block: Revision: 3 Native detailed modes: 0 Colorimetry Data Block: BT2020RGB HDR Static Metadata Data Block: Electro optical transfer functions: Traditional gamma - SDR luminance range SMPTE ST2084 Supported static metadata descriptors: Static metadata type 1 Desired content max luminance: 138 (993.486 cd/m^2) Desired content max frame-average luminance: 106 (496.743 cd/m^2) Desired content min luminance: 2 (0.001 cd/m^2) Checksum: 0x9c Unused space in Extension Block: 112 bytes ---------------- BR, -R > > > > BR, > > -R > > -- > With best wishes > Dmitry
