Re: [PATCH v15 01/10] MAINTAINERS: Include new Qualcomm CPR drivers in the file list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 15.07.2024 1:34 PM, Ulf Hansson wrote:
> On Tue, 9 Jul 2024 at 16:42, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote:
>>
>> On 09/07/2024 11:49, Konrad Dybcio wrote:
>>> On 9.07.2024 11:04 AM, Krzysztof Kozlowski wrote:
>>>> On 08/07/2024 14:22, Konrad Dybcio wrote:
>>>>> Expand the Qualcomm Core Power Reduction section to include the files
>>>>> concerning CPR3+ support.
>>>>>
>>>>> Signed-off-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>>>>> ---
>>>>>  MAINTAINERS | 5 +++--
>>>>>  1 file changed, 3 insertions(+), 2 deletions(-)
>>>>>
>>>>> diff --git a/MAINTAINERS b/MAINTAINERS
>>>>> index dcb37b635f2c..f3e013a52c16 100644
>>>>> --- a/MAINTAINERS
>>>>> +++ b/MAINTAINERS
>>>>> @@ -18687,14 +18687,15 @@ F:        Documentation/accel/qaic/
>>>>>  F: drivers/accel/qaic/
>>>>>  F: include/uapi/drm/qaic_accel.h
>>>>>
>>>>> -QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVER
>>>>> +QUALCOMM CORE POWER REDUCTION (CPR) AVS DRIVERS
>>>>>  M: Bjorn Andersson <andersson@xxxxxxxxxx>
>>>>>  M: Konrad Dybcio <konrad.dybcio@xxxxxxxxxx>
>>>>>  L: linux-pm@xxxxxxxxxxxxxxx
>>>>>  L: linux-arm-msm@xxxxxxxxxxxxxxx
>>>>>  S: Maintained
>>>>>  F: Documentation/devicetree/bindings/power/avs/qcom,cpr.yaml
>>>>> -F: drivers/pmdomain/qcom/cpr.c
>>>>> +F: Documentation/devicetree/bindings/soc/qcom/qcom,cpr3.yaml
>>>>
>>>> Maybe combine these two into:
>>>> Documentation/devicetree/bindings/power/avs/qcom,cpr*
>>>
>>> I think avs was proposed to be a subsystem/driver directory at some point
>>> and (adaptive voltage source? something like that) and this is the only file
>>> in that directory in bindings..
>>>
>>> Should we continue with this "class" of devices, or should I move qcom,cpr.yaml
>>> to soc?
>>
>> Rather cpr3 should be moved to avs or some other power directory. "soc"
>> is fallback, junkyard for things without clear domain.
> 
> In my opinion, I would suggest dropping the
> "Documentation/devicetree/bindings/power/avs/" directory. We already
> have similar bindings sprinkled across various directories, see below.
> One less seems better to me.
> 
> Documentation/devicetree/bindings/arm/*
> Documentation/devicetree/bindings/firmware/*
> Documentation/devicetree/bindings/power/*
> Documentation/devicetree/bindings/soc/*

So, should it go to bindings/power? Or should we get a new
bindings/pmdomain dir?

Konrad




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [Linux for Sparc]     [IETF Annouce]     [Security]     [Bugtraq]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]

  Powered by Linux