On Mon, Jul 15, 2024 at 07:40:22PM +0300, Dmitry Baryshkov wrote: > On Mon, 15 Jul 2024 at 17:44, Johan Hovold <johan@xxxxxxxxxx> wrote: > > > > On Mon, Jul 15, 2024 at 05:23:58PM +0300, Dmitry Baryshkov wrote: > > > The GPU on X1E80100 requires ZAP 'shader' file to be useful. Since the > > > file is signed by the OEM keys and might be not available by default, > > > disable the GPU node and drop the firmware name from the x1e80100.dtsi > > > file. Devices not being fused to use OEM keys can specify generic > > > location at `qcom/x1e80100/gen70500_zap.mbn` while enabling the GPU. > > > > Please enable the GPU for the CRD as part of this patch (e.g. move the > > fw name property there). > > I can not just move the property, as it is going to have a different > value. I think GPU enablement for CRD should come as a separate patch. The GPU is already enabled, this patch is effectively disabling it unless you move (and update) the corresponding properties to the CRD dts. Johan
